feat: add cross-language Spector tests for dollar-sign query params and discriminator without subtypes#10841
Open
iscai-msft wants to merge 7 commits into
Open
Conversation
iscai-msft
added
the
lib:http-specs
iscai-msft
requested review from
AlitzelMendez,
chrisradek,
timotheeguerin and
witemple-msft
as code owners
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
JialinHuang803
approved these changes
Jun 1, 2026
Add DollarSign interface to parameters/query with scenarios for $filter, $top/$skip, and $orderby query parameters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add Fish model with @Discriminator but no extending models to single-discriminator tests. Covers get and put scenarios. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iscai-msft
force-pushed
the
feat/cross-language-spector-tests
branch
from
4662678 to
75dc1ee
Compare
Add parameters/body-root scenario for @bodyRoot nested inside a wrapper model, testing that emitters resolve the accessor path through the wrapper (e.g. body.param) rather than referencing the property name directly. Identified from: Azure/autorest.typescript#3961 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iscai-msft
force-pushed
the
feat/cross-language-spector-tests
branch
from
75dc1ee to
c630cef
Compare
added 2 commits
June 1, 2026 12:11
…t/cross-language-spector-tests
iscai-msft
commented
Jun 1, 2026
| @@ -0,0 +1,36 @@ | |||
| import "@typespec/http"; | |||
| import "@typespec/spector"; | |||
Member
Author
There was a problem hiding this comment.
@tadelesh I added a new file and test for body root, since this nested body root didn't fit great into parameters/basic, serialization/json-encoded, or our other inheritance test types. lmk your thoughts!
tadelesh
reviewed
Jun 2, 2026
Comment on lines
+33
to
+35
| body: { | ||
| @bodyRoot bodyRootParameters: BodyRootModel; | ||
| }, |
Member
There was a problem hiding this comment.
It is a very weird usage. Can we discuss if this is a good practice first?
Comment on lines
+43
to
+77
| @scenario | ||
| @scenarioDoc(""" | ||
| Send a request with `$top` and `$skip` query parameters. | ||
|
|
||
| Expected query parameters: | ||
| - `$top` = 10 | ||
| - `$skip` = 5 | ||
|
|
||
| Expected response status code: 204 | ||
| """) | ||
| @route("/top-and-skip") | ||
| @get | ||
| topAndSkip( | ||
| @query("$top") | ||
| top: int32, | ||
|
|
||
| @query("$skip") | ||
| skip: int32, | ||
| ): void; | ||
|
|
||
| @scenario | ||
| @scenarioDoc(""" | ||
| Send a request with a `$orderby` query parameter. | ||
|
|
||
| Expected query parameter: | ||
| - `$orderby` = "name asc" | ||
|
|
||
| Expected response status code: 204 | ||
| """) | ||
| @route("/orderby") | ||
| @get | ||
| orderby( | ||
| @query("$orderby") | ||
| orderby: string, | ||
| ): void; |
Member
There was a problem hiding this comment.
These two operations seem duplicate with the first one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new cross-language Spector test scenarios identified from Go and TypeScript emitter bug fixes:
1. Dollar-sign prefixed query parameters (
parameters/query/DollarSign)Tests that emitters correctly handle
$-prefixed query parameter names on the wire (e.g.$filter,$top,$skip,$orderby). Common in OData-style APIs.2. Discriminated type without subtypes (
type/model/inheritance/single-discriminator)Tests a
@discriminator-decorated model with no extending subtypes. Emitters should still generate the polymorphic type infrastructure.Both scenarios include
main.tspdefinitions,mockapi.tsimplementations, and updatedspec-summary.md.